Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: fix AbortSignal example for stream.Readable #36596

Closed
wants to merge 1 commit into from
Closed

doc: fix AbortSignal example for stream.Readable #36596

wants to merge 1 commit into from

Conversation

targos
Copy link
Member

@targos targos commented Dec 22, 2020 •
edited
Loading

Checklist

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. stream Issues and PRs related to the stream subsystem. labels Dec 22, 2020
@benjamingr
Copy link
Member

I am also 👍 on fast tracking this if you want this to be in the next release with the API change

@targos targos added the fast-track PRs that do not need to wait for 48 hours to land. label Dec 22, 2020
targos added a commit that referenced this pull request Dec 22, 2020
@targos
doc: fix AbortSignal example for stream.Readable
2723d2d 
PR-URL: #36596
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
@targos
Copy link
Member Author

targos commented Dec 22, 2020

Landed in 2723d2d. Thanks!

@targos targos closed this Dec 22, 2020
@targos targos deleted the fix-doc-stream branch December 22, 2020 13:50
targos added a commit that referenced this pull request Dec 22, 2020
@targos
doc: fix AbortSignal example for stream.Readable
19c2332 
PR-URL: #36596
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZYSzys ZYSzys ZYSzys approved these changes

@benjamingr benjamingr benjamingr approved these changes

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land. stream Issues and PRs related to the stream subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@targos @benjamingr @ZYSzys @nodejs-github-bot